BitcoinMerged 2 days ago

LND: PR 11061 from bitromortac merged by yyforyongyu

GitHub

bolt12: add Merkle tree and BIP-340 message signatures by bitromortac · Pull Request #11061 · lightningnetwork/lnd

Part of #10736. Based on #11001. Adds Merkle tree construction over TLV records (MerkleRoot) and BIP-340 Schnorr message signatures (signMessage, v...

BitcoinMerged 3 days ago

BitcoinCore: PR 36168 from nebula-21 merged by sedited

GitHub

PSBT: Make input/output `Merge()` methods return void by nebula-21 · Pull Request #36168 · bitcoin/bitcoin

PSBT input/output Merge() methods always return true unconditionally and have no failure paths. As a result, the return value checks in PartiallySi...

BitcoinMerged 3 days ago

BitcoinCore: PR 36176 from Rob1Ham merged by achow101

GitHub

wallet: avoid a crash when creating a wallet with -nosettings by Rob1Ham · Pull Request #36176 · bitcoin/bitcoin

I hit a crash while creating a new wallet in Bitcoin-Qt 31.1 on an Apple silicon Mac with nosettings=1. After looking through the crash report and ...

BitcoinMerged 3 days ago

BitcoinCore: PR 36113 from Sjors merged by achow101

GitHub

psbt: fix rendering for invalid long sighash type field by Sjors · Pull Request #36113 · bitcoin/bitcoin

The decodepsbt incorrectly truncates the (32 bit) sighash type field before looking up its human friendly name. It's not dangerous, as such a s...

BitcoinMerged 3 days ago

WasabiWallet: PR 14786 from Carti-it merged by lontivero

GitHub

Verify blame round inputs on client side by Carti-it · Pull Request #14786 · WalletWasabi/WalletWasabi

Closed #14771 I failed to add a test that would simulate that a blame round contains a new coin. It would be great to review this code. It's a ...

BitcoinMerged 3 days ago

BitcoinCore: PR 36136 from craigraw merged by sedited

GitHub

rpc: remove stale "canonical form" claim from getdescriptorinfo help by craigraw · Pull Request #36136 · bitcoin/bitcoin

getdescriptorinfo describes its descriptor result as: The descriptor in canonical form, without private keys. The returned string is a re-seriali...

BitcoinMerged 3 days ago

BitcoinCore: PR 36127 from jeanpablojp merged by fanquake

GitHub

wallet: remove unused code by jeanpablojp · Pull Request #36127 · bitcoin/bitcoin

Six unused items in src/wallet, one per commit. DescriptorScriptPubKeyMan::AddDescriptorKey, a private wrapper that lost its caller in #28333. COut...

BitcoinMerged 4 days ago

BitcoinCore: PR 36096 from l0rinc merged by sedited

GitHub

rpc: avoid quadratic JSON construction when keys are unique by l0rinc · Pull Request #36096 · bitcoin/bitcoin

Problem: getprioritisedtransactions lets node operators inspect fee adjustments. While building the response, the RPC checks each transaction ID ag...

BitcoinMerged 4 days ago

BitcoinCore: PR 35949 from fjahr merged by sedited

GitHub

miner: Enforce Murch-Zawy rule (BIP54) by fjahr · Pull Request #35949 · bitcoin/bitcoin

Opened separate from #35793 as requested by darosior. This makes the miner enforce the murch-zawy rule for which #35793 adds the validation part. A...

BitcoinMerged 4 days ago

BitcoinCore: PR 35164 from musaHaruna merged by sedited

GitHub

test: cover P2SH sigop counting in test_witness_sigops by musaHaruna · Pull Request #35164 · bitcoin/bitcoin

Add test coverage for sigop counting in P2SH spends in test_witness_sigops(), addressing the existing TODO. The new cases mirror the existing P2WSH...

BitcoinMerged 4 days ago

BitcoinCore: PR 36161 from hebasto merged by sedited

GitHub

build: Remove `cmake/script/CoverageFuzz.cmake` by hebasto · Pull Request #36161 · bitcoin/bitcoin

The gcov-based CoverageFuzz script was introduced in 8b6f1c4, as a CMake's replacement for the legacy cov_fuzz target. However, neither cov_fuz...

BitcoinMerged 5 days ago

BitcoinCore: PR 36164 from l0rinc merged by sedited

GitHub

util: diagnose dangling views of temporary strings by l0rinc · Pull Request #36164 · bitcoin/bitcoin

Problem: Several string utilities return or store views into their input. A temporary std::string can leave these views dangling, although no curre...

BitcoinMerged 5 days ago

BitcoinCore: PR 36169 from hodlinator merged by sedited

GitHub

http: Use SO_EXCLUSIVEADDRUSE on Windows by hodlinator · Pull Request #36169 · bitcoin/bitcoin

Problem HTTPServer::BindAndStartListening() unconditionally enables SO_REUSEADDR before binding the RPC listener. On Windows, a reuse-enabled liste...

BitcoinMerged 5 days ago

BitcoinCore: PR 36123 from pinheadmz merged by sedited

GitHub

http: throttle per-connection reads while a request is in flight by pinheadmz · Pull Request #36123 · bitcoin/bitcoin

This patches a memory exhaustion scenario found while auditing the new http server with kimi-k3. A shallow version of this scenario was addressed i...

BitcoinMerged 5 days ago

BitcoinCore: PR 36166 from stickies-v merged by sedited

GitHub

validation: refactor: encapsulate Chainstate::m_target_blockhash by stickies-v · Pull Request #36166 · bitcoin/bitcoin

m_target_blockhash is paired with a mutable m_cached_target_block that must be kept in sync whenever the hash changes. Refactor, no behaviour chang...

BitcoinMerged 5 days ago

BitcoinCore: PR 36163 from nebula-21 merged by sedited

GitHub

test: Add coverage for unsatisfiable locktime combination in PSBT `ComputeTimeLock()` by nebula-21 · Pull Request #36163 · bitcoin/bitcoin

This PR adds a test case to psbt2_timelock_test covering an unsatisfiable locktime combination in PartiallySignedTransaction::ComputeTimeLock(). Wh...

BitcoinMerged 5 days ago

BitcoinCore: PR 36130 from ViniciusCestarii merged by sedited

GitHub

test: add tests in transaction_tests.cpp covering live mutants by ViniciusCestarii · Pull Request #36130 · bitcoin/bitcoin

Kills some live mutants on tx_verify.cpp that affect consensus found with https://github.com/ViniciusCestarii/mutant-harness. They are: tx_verify....

BitcoinMerged 5 days ago

BitcoinCore: PR 35738 from andrewtoth merged by sedited

GitHub

coins: parallel input prevout fetching followups by andrewtoth · Pull Request #35738 · bitcoin/bitcoin

This addresses various follow-ups requested in #35295. add the coinbase txid to the filter so inputs spending the coinbase are not fetched. delete...

BitcoinMerged 6 days ago

SeedSigner: PR 1027 from kdmukai merged by newtonick

GitHub

Clarify psbt_parser.py docstrings and comments; minor cleanup by kdmukai · Pull Request #1027 · SeedSigner/seedsigner

Clarification and cleanup after #1013 and before the next planned PR in the sequence. Some docstrings were unnecessarily over-explaining or re-expl...

BitcoinMerged 6 days ago

LND: PR 11125 from bhandras merged by yyforyongyu

GitHub

walletrpc: retain input leases through spend confirmation by bhandras · Pull Request #11125 · lightningnetwork/lnd

Change Description Add opt-in confirmation-controlled lifetimes to WalletKit output leases and PSBT funding. Some transaction protocols must keep a...