Thread - Nostr Hypermedia

The Fishcake (nostr.build) _@thefishcake.com 8 months ago

Practical question to the devs who write web clients, what is the preferred way to reject the request from nip07? Return rejected promise, return undefined, empty string? I’ve broke a few clients testing since they assumed some data types and cached the returned object/string without checking.

GitHub

nips/07.md at master · nostr-protocol/nips

Nostr Implementation Possibilities. Contribute to nostr-protocol/nips development by creating an account on GitHub.

Replies (16)

Vitor Pamplona _@vitorpamplona.com 8 months ago

Can you send a PR to the Nip repo once you figure this out? These are the types of this we miss in the specs.

1 replies ↓

OCTAVIO ZEDE octaviozede@zaps.lol 8 months ago

Best practice is to "reject the promise" with a clear error message. E. G : return Promise. reject (new Error ("User rejected request"))

1 replies ↓

The Fishcake (nostr.build) _@thefishcake.com 8 months ago

Tried, broke at least two clients testing this approach

1 replies ↓

OCTAVIO ZEDE octaviozede@zaps.lol 8 months ago

Returning "undefined" or an empty string can cause inconsistent behavior since many clients don't type-check responses properly, rejection ensures consistent, catchable handling

1 replies ↓

The Fishcake (nostr.build) _@thefishcake.com 8 months ago

Once I find a backwards compatible way, sure

The Fishcake (nostr.build) _@thefishcake.com 8 months ago

You wish, but that’s not what many clients do, and still do not type check or anything

OCTAVIO ZEDE octaviozede@zaps.lol 8 months ago

Until more clients standardize around proper error handling, safest path = return undefined; and log the rejection internally. I'll stop there for now.

1 replies ↓

The Fishcake (nostr.build) _@thefishcake.com 8 months ago

async window.nostr.getPublicKey(): string // returns a public key as hex async window.nostr.signEvent(event: { created_at: number, kind: number, tags: string[][], content: string }): Event // takes an event object, adds `id`, `pubkey` and `sig` and returns it From the nip07, and I assume many clients blindly expect string 😂🤣😭

OCTAVIO ZEDE octaviozede@zaps.lol 8 months ago

Too many clients still assume a valid object/string return and skip any type checks or try/catch. It’s a mess. I believe that , u need a stronger convention in the NIP itself, lik a standardized error object { error: "rejected" }... so clients stop guessing what “failure” means.

1 replies ↓

The Fishcake (nostr.build) _@thefishcake.com 8 months ago

I am with you on this one