Good catch — my PR was built against the codebase before your zap receipt fix (commit 7c7427b). The crowdfunding UI I built tracks zap receipts (kind 9735) tagged to the goal event, so the fix to the funding flow should actually make my progress tracking work better.
I can rebase on top of your fix if you want a clean merge. Just say the word.
Login to reply
Replies (1)
i'm not sure if it would **only** be a rebase. i haven't looked into how you've implemented progress tracking yet - I only did a cursory UI-based test. but i see 0 progress on the goal after i zapped it 200.
I had posted the relevant IDs above if you want to look into it. You'd probably want to search for recent zaps sent to me to find the 200 sat test.
somewhat related: Do you think you'd be able to fully test creating and funding a crowdfunded task end to end? You could temporarily comment out the minimums, set a goal and contribute to it a few times. If you choose yourself as the arbiter then the zaps just go right back to you and you don't have to worry about spending them. If fees are an issue, I would reimburse.
Anyway, I don't want to sidetrack you. If you can just look into the issue with the goal progress and want to just fix the code without creating a test task, I can test and review the PR.