bitcoinmerges 4 months ago

[bitcoin] Merged PR from maflcko: test: Fixup fill_mempool docstring

GitHub

test: Fixup fill_mempool docstring by maflcko · Pull Request #33269 · bitcoin/bitcoin

The assumption was removed in commit 3eab8b7.

bitcoinmerges 4 months ago

[bitcoin] Merged PR from ajtowns: Revert compact block cache inefficiencies

GitHub

Revert compact block cache inefficiencies by ajtowns · Pull Request #33253 · bitcoin/bitcoin

Reconstructing compact blocks is on the hot path for block relay, so revert changes from #28391 and #29752 that made it slower. Also add a benchmar...

bitcoinmerges 4 months ago

[bitcoin] Merged PR from fanquake: ci: use LLVM 21

GitHub

ci: use LLVM 21 by fanquake · Pull Request #33258 · bitcoin/bitcoin

Use LLVM 21 in the *san & fuzz CIs.

bitcoinmerges 4 months ago

[bitcoin] Merged PR from glozow: rpc: followups for 33106

GitHub

rpc: followups for min fee changes by glozow · Pull Request #33189 · bitcoin/bitcoin

Followups from #33106: policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee #33106 (comment) policy: lower the default blo...

bitcoinmerges 4 months ago

[bitcoin] Merged PR from kevkevinpal: threading: reduce the scope of lock in getblocktemplate

GitHub

threading: reduce the scope of lock in getblocktemplate by kevkevinpal · Pull Request #33264 · bitcoin/bitcoin

This change was motivated by #32592 (comment) It does exactly what is said in the comment. Reducing the scope of the lock by a bit before it is needed

bitcoinmerges 4 months ago

[bitcoin] Merged PR from fanquake: ci: return to using dash in CentOS job

GitHub

ci: return to using dash in CentOS job by fanquake · Pull Request #33261 · bitcoin/bitcoin

dash is available again: https://bugzilla.redhat.com/show_bug.cgi?id=2335416.

bitcoinmerges 4 months ago

[bitcoin] Merged PR from fjahr: [29.x] backport #33212

GitHub

[29.x] backport #33212 by fjahr · Pull Request #33251 · bitcoin/bitcoin

Backports #33212 to 29.x

bitcoinmerges 4 months ago

[bitcoin] Merged PR from ryanofsky: Update libmultiprocess subtree to fix build issues

GitHub

Update libmultiprocess subtree to fix build issues by ryanofsky · Pull Request #33241 · bitcoin/bitcoin

Includes: build: require CapnProto 0.7.0 or better bitcoin-core/libmultiprocess#193 ci: Add openbsd bitcoin-core/libmultiprocess#195 mpgen: Work...

bitcoinmerges 4 months ago

[bitcoin] Merged PR from theuni: threading: remove ancient CRITICAL_SECTION macros

GitHub

threading: remove ancient CRITICAL_SECTION macros by theuni · Pull Request #32592 · bitcoin/bitcoin

Now that #32467 is merged, the only remaining usage of our old CRITICAL_SECTION macros (other than tests) is in getblocktemplate() and it can safel...

bitcoinmerges 4 months ago

[bitcoin] Merged PR from mzumsande: index: Don't commit state in BaseIndex::Rewind

GitHub

index: Don't commit state in BaseIndex::Rewind by mzumsande · Pull Request #33212 · bitcoin/bitcoin

The committed state of an index should never be ahead of the flushed chainstate. Otherwise, in the case of an unclean shutdown, the blocks necessar...

bitcoinmerges 4 months ago

[bitcoin] Merged PR from stickies-v: doc: use new block_to_connect parameter name

GitHub

doc: use new block_to_connect parameter name by stickies-v · Pull Request #33237 · bitcoin/bitcoin

The parameter name was previously changed from pblock to block_to_connect in 9ba1fff, without updating the documentation. Addresses #33078 (comment).

bitcoinmerges 4 months ago

[bitcoin] Merged PR from Sjors (@Sjors Provoost): doc: follow-ups to "Add bitcoin-{node,gui} to release binaries for IPC"

GitHub

doc: follow-ups to "Add bitcoin-{node,gui} to release binaries for IPC" by Sjors · Pull Request #33233 · bitcoin/bitcoin

have dependencies.md link to the PR that updated the capnp version: Add bitcoin-{node,gui} to release binaries for IPC #31802 (comment)

bitcoinmerges 4 months ago

[bitcoin] Merged PR from maflcko: doc: Remove wrong and redundant doxygen tag

GitHub

doc: Remove wrong and redundant doxygen tag by maflcko · Pull Request #33236 · bitcoin/bitcoin

param@[in] is not a valid doxygen tag. Also, no other function in this file uses the annotations, and they are redundant with the line above, so ju...

bitcoinmerges 4 months ago

[bitcoin] Merged PR from fanquake: depends: remove xinerama extension from libxcb

GitHub

depends: remove xinerama extension from libxcb by fanquake · Pull Request #33217 · bitcoin/bitcoin

This is listed on https://doc.qt.io/qt-5.15/linux-requirements.html as "recommended", and doesn't seem to be needed (only used for wi...

bitcoinmerges 4 months ago

[bitcoin] Merged PR from sipa: miner: clamp options instead of asserting

GitHub

miner: clamp options instead of asserting by sipa · Pull Request #33222 · bitcoin/bitcoin

The BlockAssembler::ClampOptions function currently doesn't actually clamp most of the provided settings, but asserts that some are in range. T...

bitcoinmerges 4 months ago

[bitcoin] Merged PR from achow101: wallet: Remove isminetypes

GitHub

wallet: Remove isminetypes by achow101 · Pull Request #32523 · bitcoin/bitcoin

The remaining isminetypes are ISMINE_SPENDABLE and ISMINE_USED. ISMINE_USED is only used as a filter for caching balances and is never actually ret...

bitcoinmerges 4 months ago

[bitcoin] Merged PR from fanquake: doc: update example bitcoin conf for 29.1rc2

GitHub

doc: update example bitcoin conf for 29.1rc2 by fanquake · Pull Request #33234 · bitcoin/bitcoin

Followup to #33226.

bitcoinmerges 4 months ago

[bitcoin] Merged PR from glozow: [29.x] 33106 backport and final changes for rc2

GitHub

[29.x] 33106 backport and final changes for rc2 by glozow · Pull Request #33226 · bitcoin/bitcoin

Backports #33106 and includes final changes for 29.1rc2. Based on current network conditions (in which nodes rejecting 0.1-1sat/vB are missing many...

bitcoinmerges 4 months ago

[bitcoin] Merged PR from Sjors (@Sjors Provoost): Add bitcoin-{node,gui} to release binaries for IPC

GitHub

Add bitcoin-{node,gui} to release binaries for IPC by Sjors · Pull Request #31802 · bitcoin/bitcoin

Have depends make libmultiprocess by default. This PR causes the following behavior changes: bitcoin-node and bitcoin-gui binaries are included in...

bitcoinmerges 4 months ago

[bitcoin] Merged PR from stickies-v: kernel: improve BlockChecked ownership semantics

GitHub

kernel: improve BlockChecked ownership semantics by stickies-v · Pull Request #33078 · bitcoin/bitcoin

Subscribers to the BlockChecked validation interface event may need access to the block outside of the callback scope. Currently, this is only poss...