Code reviews should be objective.
But I found that I produce more useful comments if I start with the attitude "this guy is a moron and his contribution is bollocks".
So I try to force that attitude on me even if the PR is by a friend or highly respected individual 😎 👮
Login to reply
Replies (1)
I am with Andy Hunt when he says that software development is a social process. If you have two teams working on some code who seldom talk to each other, the software will have a rigid interface between two components, one by each team. And if you try to work alone, you limit yourself so much that you need a rubber duck to discuss your thoughts with.
So all combined, I try to respect whomever I work with, and try to share all my knowledge with them, so I can go on a vacation without getting calls to fix things. But indeed, when I get to a review, I imagine him being interrupted by his mother-in-law every few minutes in his home office, or her being on her period and wanting to get off their chair as soon as possible.
This leaves me a chance to love them as a person and be graceful for having their experience as a teammate, but makes me aware that we are just irrational monkeys hammering on keyboards, who could never get to the Moon working alone.